Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl del deletes file even when focused on document editor #629

Closed
benjamin22-314 opened this issue Jan 30, 2021 · 5 comments · Fixed by #631, #664 or #666
Closed

Ctrl del deletes file even when focused on document editor #629

benjamin22-314 opened this issue Jan 30, 2021 · 5 comments · Fixed by #631, #664 or #666
Assignees
Labels
not a bug Invalid: Feature, not a bug potential feature Request: May be considered later

Comments

@benjamin22-314
Copy link

benjamin22-314 commented Jan 30, 2021

Ctrl del deletes file even when focused on document editor, instead of deleting the word after the cursor like expected.

Steps to recreate issue;

Open Project.
Press Alt 1 to focus on project tree.
Select file to write in.
Press Alt 2 to focus on document editor.
Write in the document editor.
Press Ctrl del.

@benjamin22-314 benjamin22-314 added the bug Issue: Something isn't working label Jan 30, 2021
@vkbo
Copy link
Owner

vkbo commented Jan 31, 2021

Ctrl+Del is a menu shortcut for the delete item entry. The QTextEdit widget does not support Ctrl+Del (or Ctrl+Backspace). This is not a bug.

It's a potential feature suggestion though.

@vkbo vkbo added not a bug Invalid: Feature, not a bug potential feature Request: May be considered later and removed bug Issue: Something isn't working labels Jan 31, 2021
@vkbo
Copy link
Owner

vkbo commented Jan 31, 2021

That said, it's probably a good idea to block the key press when the editor has focus, even if the menu entry itself works.

@vkbo vkbo self-assigned this Jan 31, 2021
@vkbo vkbo linked a pull request Jan 31, 2021 that will close this issue
@vkbo vkbo removed a link to a pull request Jan 31, 2021
vkbo added a commit that referenced this issue Jan 31, 2021
@vkbo vkbo linked a pull request Jan 31, 2021 that will close this issue
@vkbo
Copy link
Owner

vkbo commented Jan 31, 2021

The focus requirement has been merged to main. I'll leave this open for the other two features.

@vkbo vkbo added this to the Release 1.3 RC 1 milestone Feb 10, 2021
@vkbo vkbo linked a pull request Feb 11, 2021 that will close this issue
@vkbo
Copy link
Owner

vkbo commented Feb 11, 2021

So, I did some testing, and it turns out that Ctrl+Backspace and Ctrl+Del actually do work. However, they aren't documented in the Qt documentation. I found out by disabling the existing Ctrl+Del shortcut currently used for deleting files in the project tree.

I'll free up this shrotcut again by changing the delete item shortcut to Ctrl+Shift+Del instead. It should be available in the next testing release for version 1.2. I released 1.2 Beta 1 today, but didn't check this until after. The fix is in PR #664.

@vkbo
Copy link
Owner

vkbo commented Feb 11, 2021

Also back ported the fix to be included in the 1.1.1 patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not a bug Invalid: Feature, not a bug potential feature Request: May be considered later
Projects
None yet
2 participants