Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appimage Distribution #1092

Merged
merged 7 commits into from Jul 15, 2022
Merged

Appimage Distribution #1092

merged 7 commits into from Jul 15, 2022

Conversation

Ryex
Copy link
Contributor

@Ryex Ryex commented Jul 8, 2022

Summary:

Adds a build-appimage command to the setup.py that builds off the existing build-debian command to package the source and then writes the appropriate metadata files to a dist_appimage directory.

requires python-appimage package to be installed via pip to succeed.

Related Issue(s):

#1091

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo linked an issue Jul 9, 2022 that may be closed by this pull request
@vkbo vkbo added this to the Release 1.7 RC 1 milestone Jul 9, 2022
@vkbo
Copy link
Owner

vkbo commented Jul 15, 2022

Thanks a lot for contributing this. I made a few minor changes to the setup function, and tested it. I had no problem building it and running it.

Just a FYI: I reverted the change of spelling. Everything in novelWriter is UK English. That's the version I learned :)

@vkbo vkbo merged commit b30a4d2 into vkbo:main Jul 15, 2022
@Ryex Ryex deleted the appimage-dist branch July 15, 2022 18:42
@vkbo vkbo mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appimage Distribution
2 participants