Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing data path issue when creating themes folders #1184

Merged
merged 1 commit into from Oct 18, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 18, 2022

Summary:

The folder for custom GUI and syntax themes were attempted created before the data folder for novelWriter was created. This printed four error messages the first tome novelWriter was run on a new system. The problem resolved itself on the second run.

The error was handled, and the folders in question are read-only, so the error was trivial.

In the same PR, the functions to set dataPath and confPath in the main config object have been removed. They are not in use, neither by the app nor the test suite. A new common function to both check for and create folders at the same time, has been added. This is useful also elsewhere in the code.

Related Issue(s):

Resolves #1180

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0 RC 2 milestone Oct 18, 2022
@vkbo vkbo merged commit 1aec49f into main Oct 18, 2022
@vkbo vkbo deleted the fix_create_theme_dir branch October 18, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors on startup: Could not create folder: /home/yuri/.local/share/novelwriter/syntax
1 participant