Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config class, and switch to pathlib #1228

Merged
merged 9 commits into from Nov 9, 2022
Merged

Refactor config class, and switch to pathlib #1228

merged 9 commits into from Nov 9, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 9, 2022 •
edited

Summary:

This PR cleans up the Config class a bit, especially when it comes to handling paths. It also replaced os.path with pathlib nearly everywhere.

Related Issue(s):

Closes #1224

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0 RC 2 milestone Nov 9, 2022
@vkbo vkbo merged commit eac7d9b into main Nov 9, 2022
@vkbo vkbo deleted the refactor_config branch November 9, 2022 22:03
@vkbo vkbo mentioned this pull request Nov 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0 RC 2
Development

Successfully merging this pull request may close these issues.

Refactoring: Config class
1 participant
@vkbo