Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor stats handling and test coverage #1725

Merged
merged 5 commits into from
Mar 3, 2024
Merged

Improve editor stats handling and test coverage #1725

merged 5 commits into from
Mar 3, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Mar 3, 2024

Summary:

This PR makes a few improvements to how the editor processes changes of the document content. The percentage counter in the footer is now showing cursor position percentage, not line percentage, and the logic of how these stats are processed internally has been refactored. Test coverage has also been improved on this and the search functionality.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4 Beta 1 milestone Mar 3, 2024
@vkbo vkbo merged commit 7799e9f into dev Mar 3, 2024
9 checks passed
@vkbo vkbo deleted the improvements branch March 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant