Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n issues #1744

Merged
merged 2 commits into from Mar 11, 2024
Merged

Fix i18n issues #1744

merged 2 commits into from Mar 11, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Mar 10, 2024 •
edited

Summary:

This PR fixes:

  • Header in Project Word List dialog bypasses translation.
  • Norwegian translation has a discrepancy between Crowdin and the ts file even after update.

Related Issue(s):

Closes #1746

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3.1 milestone Mar 10, 2024
@vkbo vkbo mentioned this pull request Mar 11, 2024
Closed
@vkbo vkbo linked an issue Mar 11, 2024 that may be closed by this pull request
Project Word List window shows untranslated string #1746
Closed
@vkbo vkbo merged commit 27ea697 into main Mar 11, 2024
9 checks passed
@vkbo vkbo deleted the i18n_fixes branch March 11, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.3.1
Development

Successfully merging this pull request may close these issues.

Project Word List window shows untranslated string
1 participant
@vkbo