Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert font setting in custom class #1941

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Revert font setting in custom class #1941

merged 1 commit into from
Jun 20, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 20, 2024

Summary:

This PR reverts a change from #1940 that uses a font from theme when setting the default font in the custom colour label class. This caused some strange behaviour likely due to a loop somewhere when loading the Preferences dialog, which uses it multiple times.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 20, 2024
@vkbo vkbo merged commit f662eae into main Jun 20, 2024
8 checks passed
@vkbo vkbo deleted the revert_colorlabel branch June 20, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant