Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #21

Merged
merged 17 commits into from May 26, 2019
Merged

Improvements #21

merged 17 commits into from May 26, 2019

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 26, 2019

A bunch of little improvements to the GUI and code

Status Bar

  • Redesign of the status bar adding project and session stats as well as a session timer.
  • Project word count is written to the project file, which is needed for the session word count.
  • Closing a project now clears the status bar.

Editor

  • Spell checker now ignores lines staring with @ and words in all uppercase.
  • A document can be closed, which also clears it from last edited document in the project file. I.e. it is not re-opened on next start.
  • Tab width is now by default 40 pixels, and can be set in the config.

Bugfixes

  • Closing the application with the window X button, and selecting No on the dialog, still closed the application. Properly handled the close event now so that the closing is cancelled.

@codecov-io
Copy link

Codecov Report

Merging #21 into master will increase coverage by 0.36%.
The diff coverage is 85.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   80.68%   81.04%   +0.36%     
==========================================
  Files          23       23              
  Lines        3215     3313      +98     
==========================================
+ Hits         2594     2685      +91     
- Misses        621      628       +7
Impacted Files Coverage Δ
nw/gui/dochighlight.py 100% <100%> (ø) ⬆️
nw/gui/doceditor.py 66.78% <100%> (+0.59%) ⬆️
nw/gui/mainmenu.py 96.23% <100%> (+0.06%) ⬆️
nw/constants.py 100% <100%> (ø) ⬆️
nw/gui/winmain.py 69.47% <41.5%> (-1.46%) ⬇️
nw/gui/doctree.py 45.93% <91.66%> (+1.71%) ⬆️
nw/config.py 94.71% <96.38%> (-0.58%) ⬇️
nw/gui/statusbar.py 97.24% <96.96%> (+2.08%) ⬆️
nw/project/project.py 79.15% <97.36%> (+1.3%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f9b37...5c20075. Read the comment docs.

@vkbo vkbo merged commit a9bf8a8 into master May 26, 2019
@vkbo vkbo deleted the improvements branch May 26, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants