Editor Focus and Enter Key Behaviour #412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few clumsy issues with how the tab and enter keys work in the editor panel.
Main Fix
The Qt widget itself disables the tab key as a focus changing key, which makes sense since you want to be able to type tabs. However, since the search box sits on top of the editor, the tab key would still write to the text editor even if the search box had focus.
Previously, this was solved by blocking the tab key entirely when the search box was in focus, but not the replace box. This has now been changed to block the focus change event itself when the editor is in focus, and alternate between focus and replace when it's not.
The return AND enter keys are now properly captured to move the search forward, and only those keys are blocked.
Additional Fixes
Ctrl+Shift+Z
to redo last undo has been re-activated. The standard sequence is stillCtrl+Y
.