Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #438: Editor cut/copy/paste #439

Merged
merged 5 commits into from Sep 6, 2020
Merged

Issue #438: Editor cut/copy/paste #439

merged 5 commits into from Sep 6, 2020

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Sep 6, 2020

This PR adds:

Document Editor

  • Cut and Copy to the context menu when a user has made a selection.
  • Paste, Select All, Select Word and Select Paragraph to the context menu.
  • Spell checking is added to the same menu if any suggestions are available.
  • Select Word and Paragraph selects the word/paragraph under the pointer, not the cursor as the equivalent main menu entries do.

Document Viewer

  • Removes the built-in context menu and replaces it with the Paste, Select All, Select Word and Select Paragraph features from the document editor context menu.

These changes makes them consistent (the built-in menu looks different than the other menus) and the editor and viewer are now consistent in features and functionality with each other.

Tests have been added to check that the selection functions work in both panels and the context menu can be built without crashing (no other functionality checks are made on the context menu itself).

@vkbo vkbo linked an issue Sep 6, 2020 that may be closed by this pull request
@vkbo vkbo merged commit 82b064f into main Sep 6, 2020
@vkbo vkbo deleted the issue438_copy-paste branch September 8, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut, Copy, Paste in editor
1 participant