Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend search feature to allow replace as well #51

Merged
merged 1 commit into from Oct 6, 2019
Merged

Extend search feature to allow replace as well #51

merged 1 commit into from Oct 6, 2019

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 6, 2019

Search/replace now fully implemented, although only for currently edited document

This completes issue/feature #48

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3b34408). Click here to learn what that means.
The diff coverage is 52.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage          ?   74.52%           
=========================================
  Files             ?       30           
  Lines             ?     4930           
  Branches          ?        0           
=========================================
  Hits              ?     3674           
  Misses            ?     1256           
  Partials          ?        0
Impacted Files Coverage Δ
nw/enum.py 100% <100%> (ø)
nw/gui/mainmenu.py 93.61% <100%> (ø)
nw/gui/winmain.py 69.34% <33.33%> (ø)
nw/gui/doceditor.py 62.53% <5.88%> (ø)
nw/gui/searchbar.py 73.8% <74.46%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b34408...d91d77d. Read the comment docs.

@vkbo vkbo merged commit 0f00c95 into master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants