Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon cleanup #53

Merged
merged 4 commits into from Oct 6, 2019
Merged

Icon cleanup #53

merged 4 commits into from Oct 6, 2019

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 6, 2019

This PR removes icons from the main menu and context menu, and adds a set of simple icons for the dark theme. The systems theme will still pull the default OS icons.

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #53 into master will increase coverage by <.01%.
The diff coverage is 87.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   74.46%   74.47%   +<.01%     
==========================================
  Files          30       30              
  Lines        4934     4955      +21     
==========================================
+ Hits         3674     3690      +16     
- Misses       1260     1265       +5
Impacted Files Coverage Δ
nw/gui/doceditor.py 62.03% <0%> (+0.16%) ⬆️
nw/gui/configeditor.py 5.73% <0%> (-0.02%) ⬇️
nw/gui/searchbar.py 74.11% <100%> (+0.3%) ⬆️
nw/gui/mainmenu.py 93.61% <100%> (ø) ⬆️
nw/gui/projecteditor.py 93.61% <100%> (+0.01%) ⬆️
nw/gui/doctree.py 51.37% <66.66%> (+0.13%) ⬆️
nw/theme.py 61.76% <75%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bde444...8fc3de2. Read the comment docs.

@vkbo vkbo merged commit 1e9f99f into master Oct 6, 2019
@vkbo vkbo deleted the icon_cleanup branch October 19, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants