Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #58

Merged
merged 3 commits into from
Oct 20, 2019
Merged

Bugfixes #58

merged 3 commits into from
Oct 20, 2019

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 20, 2019

This PR addresses the following problems:

  • The backup request dialog should pop up on any change to the project during the last session, not just on unsaved changes as it currently does.
  • The regex that searches for words for the spell check highlighter was not including unicode characters, so it would underline parts of words using unicode characters even if the word was spellec correctly.
  • When having unsaved changes in an open document, while changing editor configuration options, the document would be reloaded from disk when the changes were applied. This means the unsaved changes were lost. The document is now saved before the editor is re-initialised.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6638c51). Click here to learn what that means.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage          ?   66.77%           
=========================================
  Files             ?       36           
  Lines             ?     5781           
  Branches          ?        0           
=========================================
  Hits              ?     3860           
  Misses            ?     1921           
  Partials          ?        0
Impacted Files Coverage Δ
nw/gui/configeditor.py 5.73% <0%> (ø)
nw/project/project.py 82.44% <100%> (ø)
nw/gui/dochighlight.py 93.38% <100%> (ø)
nw/gui/winmain.py 68.82% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6638c51...79116f8. Read the comment docs.

@vkbo vkbo merged commit 70b3b24 into master Oct 20, 2019
@vkbo vkbo deleted the fixes branch October 21, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants