Issue #608: Missing Cursor #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #608 which describes an issue with opening a blank document and no cursor being visible when the editor has focus.
I did not manage to find out why this happens. Presumably, some action by novelWriter causes the cursor to not show. I added a simple hack that will add a line break and remove it again if the opened document is empty. This brings back the cursor. However, it doesn't work if the blank document is opened automatically when the application is launched. The latter is why I expect it is caused by a conflict with some other internal feature. Still, fixing it for when the user manually opens a blank document solves it in 99% of cases, and it's probably good enough.
If I figure out exactly what is causing this, I'll make a better fix.