Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Text File #65

Merged
merged 7 commits into from Oct 23, 2019
Merged

Import Text File #65

merged 7 commits into from Oct 23, 2019

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 23, 2019

This partially addresses request #63

This change makes it possible to fill an open document file with content loaded from a text file. The option is accessible from the menu under Document > Import from File, or by pressing Ctrl+Shift+I. This will open a file dialog box allowing the user to select a text file to import. A document in the editor must be open beforehand, and the content will be replaced. A dialog box will check that it is OK to replace the text in the case the document is not empty.

Trying to load a binary file will cause an error. The file read must be readable by Python3 as a text file. and convertible to plain text.

@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #65 into master will decrease coverage by 0.31%.
The diff coverage is 28.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   65.74%   65.42%   -0.32%     
==========================================
  Files          38       38              
  Lines        6078     6132      +54     
==========================================
+ Hits         3996     4012      +16     
- Misses       2082     2120      +38
Impacted Files Coverage Δ
nw/constants.py 100% <ø> (ø) ⬆️
nw/gui/doctree.py 50.26% <0%> (-1.11%) ⬇️
nw/gui/itemeditor.py 95.87% <100%> (ø) ⬆️
nw/gui/mainmenu.py 93.86% <100%> (+0.09%) ⬆️
nw/gui/winmain.py 64.83% <3.44%> (-3.57%) ⬇️
nw/gui/doceditor.py 61.96% <50%> (-0.07%) ⬇️
nw/config.py 95.18% <88.88%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aeffdd...dc12d51. Read the comment docs.

@vkbo vkbo merged commit 0d5899e into master Oct 23, 2019
@vkbo vkbo deleted the new_doc_from_file branch October 24, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants