Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make writing stats word calculation more intuitive #659

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 9, 2021

The session log file actually logs the total word count for each entry, not the change in words. The writing stats dialog calculates the difference and list the change in word count per row. However, when the negative word counts are filtered out, the difference displayed in the next positive word count row is calculated from the difference from before the skipped row, so the total count may no longer actually be positive.

Example:

Day 1: +2000 words
Day 2: -500 words
Day 3: +1500 words

Filtering out the negative would then show:

Day 1: +2000 words
Day 3: +1000 words

With this change, it instead shows:

Day 1: +2000 words
Day 3: +1500 words

This makes more sense, but it also means that the sum of rows no longer matches the total word count if negative counts are excluded. But that is sort of expected, so not really an issue.

@vkbo vkbo added this to the Release 1.1.1 milestone Feb 9, 2021
@vkbo vkbo merged commit b47c4c8 into main Feb 9, 2021
@vkbo vkbo deleted the writing_stats_calc branch February 9, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant