Issue #773: Fix QTranslate() filePath issue #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkbo
force-pushed
the
issue773_qtranslate_filepath
branch
from
837dc06
to
7311471
Compare
vkbo
force-pushed
the
issue773_qtranslate_filepath
branch
from
7311471
to
22e8d7e
Compare
vkbo
force-pushed
the
issue773_qtranslate_filepath
branch
from
1822edf
to
9ff397d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function called was only added in Qt 5.15: https://doc.qt.io/qt-5/qtranslator.html#filePath
Also add a GitHub action to run the tests under minimum package dependencies to try to detect such bugs early.The old package setup doesn't really work because the test environment isn't designed for outdated packages. Need to run a virtualbox locally instead.
Resolves #773