Added Vector.eachNonZero method and implementations (issue #57) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -235,6 +235,13 @@ public void each(VectorProcedure procedure) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void eachNonZero(VectorProcedure procedure) { | |||
There was a problem hiding this comment.
It is not necessary to check value in compressed vector on zero. It is guaranteed that only non-zero values are store. Which means, that we only need to rename each to eachNonZero in CompressedVector class. Please also make sure that MatrixMarketStream uses the proper iteration method. TIP: It should be eachNonZero.
| @@ -276,6 +276,11 @@ public void each(VectorProcedure procedure) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void eachNonZero(VectorProcedure procedure) { | |||
| self.each(procedure); | |||
There was a problem hiding this comment.
Should be each.nonZero(procedure).
|
Looks good! Just one thing's left (see my comments below). |
|
Nice job Maxim @SamoylovMD! |
vkostyukov
added a commit
that referenced
this pull request
Aug 3, 2013
Added Vector.eachNonZero method and implementations (issue #57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.