This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Allow empty filters - "is not None" #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct the <get> and <get-config> operations to avoid ignoring filter_criteria when it doesnot contain any child * make it PEP8 Programmer Recommandation (line 1102) and Google section 2.14.4 * Remove the FutureWarning raised by LXML, which appear for any filter. (only if `use_lxml=True`) due to __bool__ method of the class Element of LXML.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the issue #13 : changes the Get and Get Config keywords to avoid ignoring filter_criteria when filter_criteria doesnot contain any child.
Additionally:
if xwhen you really meanif x is not None"; and Google section 2.14.4 bullet 2 "Always useif foo is None: (oris not None) to check for aNonevalue."use_lxml=True) due to bool method of the class Element of LXML.