Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Property Types JSON Auto Generated & Update With New 2021 Types #49

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

alexkcode
Copy link
Collaborator

Creates a json for property types piggybacking off of the property types variable created in src/data/scripts/add-context-by-property-type.py. Outputs in some unicode escape sequences but those render fine in the frontend.

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit bb3499c
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/6501106d3678fb0008bd8d0f
😎 Deploy Preview https://deploy-preview-49--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vkoves vkoves self-assigned this Sep 13, 2023
@vkoves
Copy link
Owner

vkoves commented Sep 15, 2023

I found the one french tagged building... it's a Target 😆

Screenshot from 2023-09-14 20-30-35

@vkoves vkoves changed the title added json output logic for prop types Make Property Types JSON Auto Generated & Update With New 2021 Types Sep 15, 2023
Copy link
Owner

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, awesome work! I might submit a support ticket for that weird category with the city 😆

@vkoves vkoves merged commit 19a0e7f into main Sep 15, 2023
7 checks passed
@alexkcode
Copy link
Collaborator Author

alexkcode commented Sep 15, 2023 via email

@vkoves vkoves deleted the issue-43-prop-types branch March 6, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants