Add keyword continue, break, pass in lexer, parser #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 19, 2024
vla5924
requested changes
May 25, 2024
| ctx.tokenIter->is(Keyword::Pass)); | ||
| ctx.goNextToken(); | ||
| if (!ctx.token().is(Special::EndOfExpression)) { | ||
| ctx.pushError("Unexepted tokens after control flow keyword"); |
There was a problem hiding this comment.
- я думаю сообщение должно быть более конкретным: Unexpected token in a break|continue|pass statement.
- в случае этой ошибки нужно явно перейти на следующее выражение, ctx.goNextExperssion()
| @@ -433,6 +433,17 @@ std::stack<SubExpression> generatePostfixForm(TokenIterator tokenIterBegin, Toke | |||
| return postfixForm; | |||
| } | |||
|
|
|||
| void parseControlFlowStatement(ParserContext &ctx) { | |||
There was a problem hiding this comment.
pass не влияет на control flow, лучше parseSimpleStatement или что-нибудь такое
| @@ -1193,6 +1193,53 @@ TEST(Parser, can_parse_for_enumerate) { | |||
| ASSERT_EQ(expected, tree.dump()); | |||
| } | |||
|
|
|||
| TEST(Parser, can_parse_pass_continue_break_loops) { | |||
There was a problem hiding this comment.
наверное для pass лучше сделать отдельный тест? он же не только в цикле может быть, а где угодно
| }; | ||
| TokenList tokens = Lexer::process(source); | ||
| SyntaxTree tree = Parser::process(tokens); | ||
| std::string expected = "ProgramRoot\n" |
There was a problem hiding this comment.
как смотришь на использование DeclarativeTree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.