Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcode is displayed in a small scrollable frame. #1885

Open
Git-Bruno opened this issue Apr 28, 2024 · 3 comments
Open

gcode is displayed in a small scrollable frame. #1885

Git-Bruno opened this issue Apr 28, 2024 · 3 comments

Comments

@Git-Bruno
Copy link
Contributor

The frame showing the gcode is a small scrollable frame that cannot be enlarged to occupy the entire frame at the left of the bCNC window. This is with the last master branch, code dated Apr,22,2024.
bCNC_gcode_window

@Harvie
Copy link
Collaborator

Harvie commented Apr 29, 2024

Thanks for noticing this. i did not. wonder which commit had introduced it...

@Harvie Harvie added this to the 0.9.16 milestone Apr 29, 2024
@Git-Bruno
Copy link
Contributor Author

This was introduced on Fev 09 by PR#1849, Vertical scrollbar to make small screens easier to use. bmain.py was changed to use VScrollFrame.py.
If I replace bmain.py with a copy not using VScrollFrame.py then the gcode fills the entire left frame.
I tested previous versions and the left frame in the Editor page was already scrollable by default.
To me the code introduced by PR#1849 should either not apply when in the Editor page or , for all pages, always adapt the size of the left frame to the screen size and make it scrollable when the content cannot fit in the frame.

@ownedcore
Copy link

Observing the same with a Debian 12 installation. Also cant figure out which version of bCNC i actually have installed. Though I have the VScrollFrame.py file.

If I change line 39 of VScrollFrame.py and add ", height=event.height" the frame gets all down to the bottom (Editor tab). Also this renders the ability to scroll down, if the left side frame is not occupying the whole window. Tested on "File" tab.

Other thing i notice without the change to VScrollFrame.py and the height addition is that i can scroll the left side up when its not fully occupying available space.

Im not familiar with tk so cant help, just wanted to share my obversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants