Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openconnect-sso running under windows #96

Closed
wants to merge 1 commit into from

Conversation

alyssadev
Copy link

At least when using scoop to install sudo. I'm not sure if others use other methods to have a working system for sudo on windows

At least when using scoop to install sudo. I'm not sure if others use other methods to have a working system for `sudo` on windows
@Beej126
Copy link

Beej126 commented Sep 17, 2022

i'm curious what people think about eliminating the sudo execution under Windows and just running the initial openconnect-sso process as elevated so it's subsequent launch of openconnect.exe will also be elevated.

i started capturing Windows specifics like this under a fork in case it helps others... also ready to align with anywhere else this has already been done and eliminate my extra noise.

as an aside, here's my favorite sudo for Windows... it's a pretty slick approach of capturing stdin/out of the hidden elevated process and piping that back to your initial console so it looks more like what we're used to on linux... works well in general but in this case, sending CTRL-C/SIGNINT to openconnect.exe is important for cleanup after disconnect and it doesn't seem to pass that through... could probably be coded, i'm assuming the author just didn't consider it yet.

@alyssadev
Copy link
Author

Very cool changes you've got there. I'd be in favour of pulling some of those, my change is pretty half-baked, it works in my case but isn't much use outside of that

@alyssadev alyssadev closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants