Fix empty value on publish page

vlad-ghita · Sep 11, 2012 · be780a8 · be780a8
1 parent 740f86b
commit be780a8
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/fields/field.url.php b/fields/field.url.php
@@ -152,15 +152,15 @@ public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWit
 				// Type internal
 				$label = Widget::Label();
 				$input = Widget::Input($base_name.'[url_type]'.$postfix, 'internal', 'radio');
-				$input->setAttribute('data-target','internal');
+				$input->setAttribute('data-target', 'internal');
 				if( $type === 'internal' || empty($type) ) $input->setAttribute('checked', 'checked');
 				$label->setValue(__('%s Internal', array($input->generate())));
 				$div->appendChild($label);
 
 				// Type external
 				$label = Widget::Label();
 				$input = Widget::Input($base_name.'[url_type]'.$postfix, 'external', 'radio');
-				$input->setAttribute('data-target','external');
+				$input->setAttribute('data-target', 'external');
 				if( $type === 'external' ) $input->setAttribute('checked', 'checked');
 				$label->setValue(__('%s External', array($input->generate())));
 				$div->appendChild($label);
@@ -273,7 +273,7 @@ public function processRawFieldData($data, &$status, &$message = null, $simulate
 			if( isset($data['url_type']) ){
 				$result = array(
 					'url_type' => $data['url_type'],
-					'value' => $data[ 'value_'.$data['url_type'] ]
+					'value' => $data['value_'.$data['url_type']]
 				);
 			}
 
@@ -286,19 +286,19 @@ public function processRawFieldData($data, &$status, &$message = null, $simulate
 		/*  Output  */
 		/*------------------------------------------------------------------------------------------------*/
 
-		public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null) {
-			if(!is_array($data) || empty($data) || is_null($data['value'])) return;
+		public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null){
+			if( !is_array($data) || empty($data) || is_null($data['value']) ) return;
 
 			$result = new XMLElement($this->get('element_name'));
-			$result->setAttribute('type',$data['url_type']);
+			$result->setAttribute('type', $data['url_type']);
 
 			switch( $data['url_type'] ){
 				case 'external':
 					$result->setValue($data['value']);
 					break;
 
 				case 'internal':
-					$result->setAttribute('id',$data['value']);
+					$result->setAttribute('id', $data['value']);
 					$related_value = $this->findRelatedValues(array($data['value']));
 					$result->setValue(URL . $related_value[0]['value']);
 					break;
@@ -319,8 +319,8 @@ public function prepareTableValue($data, XMLElement $link = null, $entry_id = nu
 
 			switch( $data['url_type'] ){
 				case 'external':
-					$link = $data['value'];
-					$label = $data['value'];
+					$link = empty($data['value']) ? false : $data['value'];
+					$label = empty($data['value']) ? __("No data") : $data['value'];
 					break;
 
 				case 'internal':