-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"onTouchStart" preventDefault is ignored, causes double step to happen #44
Comments
Same issue here |
Reproduced in react-numeric-input v2.0.9 and 2.1.0 in desktop Chrome in device mode and latest Chrome browser on Android. |
Hi @vlad-ignatov, Made a quick fix on this issue according to recommendation on developers.google.com:
Please review and merge if appropriate, this fixes the double click issue in devtools' device mode so should work on mobiles with touch events: #56 |
This is now fixed thanks to @lanceon. |
This was tested on Chrome 58 with responsive mode switched on which means it treats clicks as touch events. This results in step being done twice on a single click.
The following message gets logged in the console.
[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080
The text was updated successfully, but these errors were encountered: