-
Notifications
You must be signed in to change notification settings - Fork 0
/
netcat-package-and-code-review.html
7 lines (7 loc) · 4.58 KB
/
netcat-package-and-code-review.html
1
2
3
4
5
6
7
<html><body>
<head>
<title>Netcat package and code review | Oracle Czech techie's adventures Blog</title>
<meta name="publish_date" content="2007-11-02 16:46:54">
</head>
<p>As you might know, <a href="http://en.wikipedia.org/wiki/Netcat">Netcat</a> implementation <br/>is going to be part of <a href="http://www.opensolaris.org/">OpenSolaris</a>. <br/>The initial Netcat integration is based on a <br/><a href="http://opengrok.creo.hu/openbsd/xref/src/usr.bin/nc/">reimplementation</a> from<br/><a href="http://www.openbsd.org/">OpenBSD</a> (<a href="http://blogs.sun.com/vlad/resource/netcat-implementations.txt">here</a>'s why).</p><p>As <a href="http://blogs.sun.com/bonwick/">Jeff Bonwick</a> <a href="http://blogs.sun.com/storage/entry/what_we_re_watching_the">said</a>, open sourced code is nothing compared to the fact that all design discussions and decisions suddenly happen in the public (loosely paraphrased). This is a great wave to ride and I have jumped on it<br/>when it was not really small so I have at least <a href="http://mail.opensolaris.org/pipermail/opensolaris-code/2007-October/006311.html">posted</a> the <a href="http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/tools/scripts/webrev.sh">webrev</a> pointer for initial Netcat integration (CR <a href="http://bugs.opensolaris.org/view_bug.do?bug_id=4664622">4664622</a>) to the <a href="http://mail.opensolaris.org/mailman/listinfo/opensolaris-code">opensolaris-code</a> mailing list (which is roughly the equivalent of <a href="http://marc.info/?l=freebsd-hackers&r=1&w=2">freebsd-hackers</a>, <a href="http://marc.info/?l=openbsd-tech&r=1&w=2">openbsd-tech</a> or similar mailing lists)<br/>to get some code review comments.</p><p>Since then couple of things changed. Thanks to <br/><a href="http://blogs.sun.com/dp/">Dan Price</a> and others<br/>it's<br/><a href="http://blogs.sun.com/dp/entry/cr_opensolaris_org_now_live">now possible</a><br/>to upload <a href="http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/tools/scripts/webrev.sh">webrevs</a> to <a href="http://cr.opensolaris.org">cr.opensolaris.org</a>.<br/>I have started using the service so the new and official place for the Netcat webrev is</p><ul><a href="http://cr.opensolaris.org/~vkotal/netcat-webrev/">cr.opensolaris.org/~vkotal/netcat-webrev/</a></ul><p>The webrev has moved location but what I said in the opensolaris-code post still holds<br/>true:</p><p><i><br/>Any constructive notes regarding the code are welcome. (I am mainly <br/>looking for functional/logic errors, packaging flaws or parts of code <br/>which could mismatch the PSARC case)<br/></i></p><p>The following things could help any potential code reviewer:</p><ul><li><a href="http://blogs.sun.com/vlad/resource/changes-netcat.txt">Summary of the changes</a> done to the original implementation in order to adapt it to Solaris environment.. </li><li><a href="http://www.opensolaris.org/os/community/arc/caselog/2007/389/">PSARC 2007/389</a> case covering interfaces delivered by this project. For more information<br/>about ARCs see <a href="http://www.opensolaris.org/os/community/arc/">Architecture Process and Tools</a> community pages.</li><li><a href="http://cr.opensolaris.org/~vkotal/SUNWnetcat-x86.tar">SUNWnetcat package (x86)</a> which contains <tt>/usr/bin/nc</tt> binary</li><li><a href="http://cr.opensolaris.org/~vkotal/webrev.netcat-versus-OpenBSD/">webrev <br/> of the differences</a> between my version of Netcat and the one which is<br/> currently in OpenBSD.<br/><br/> Only the <tt>\*.[ch]</tt> files matter, of course. (This is very <br/> easy thing to do with distributed SCM since it only requires one to reparent and <br/> regenerate webrev against new parent workspace)</li><li><a href="http://blogs.sun.com/vlad/resource/netcat-updated-manpage.txt">Updated<br/> manual page</a></br><br/> This is slightly different from the man page in the PSARC materials because it contains<br/> new section about using nc with privileges and associated set of examples in the EXAMPLES<br/> section. The man page in the PSARC materials will not be updated because after a case<br/> is approved, the man page is updated only in case some architectural changes were<br/> needed. In the case of privileges, it is only addition describing specific usage,<br/> no architectural changes.</li></ul><p>The conclusion for non code reviewers ? I hope it is clear the in (Open)Solaris land<br/>we value quality and transparency. Peer reviews and architectural reviews are just<br/>(albeit crucial) pieces which help to achieve that goal.</p>
</body></html>