small cleanup in QGeoTileFetcherGooglemaps and questions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup unused variables such as _versionGoogleMap and the related logic. QGeoTileFetcherGooglemaps::QGeoTileFetcherGooglemaps() - remove some commented out code QGeoTileFetcherGooglemaps::_googleVersionCompleted() - remove regex calls that update the version strings, yet said version strings are unused Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
_getServerNum() is unused and a warning is thrown about it when building with -W flags. Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
|
thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello Vladyslav,
i'm participating in a open source project where we just recently added a Qt Location based map widget:
https://github.com/Subsurface-divelog/subsurface
after not being happy with the bundled ESRI geolocation plugin, we found your google maps plugin, for which we would like to thank you - it works and it seems to suit our needs for now! we are probably going to fork your repository and always base our builds on that, but still send patches and PRs upstream back to you:
https://github.com/Subsurface-divelog/googlemaps
in this PR there are a couple of small changes that remove some unused variables and code from QGeoTileFetcherGooglemaps. i'm not exactly sure if there are plans to keep this code for later or if it's for debugging purposes, so please let me know if my changes are not appropriate.
thanks
lubomir