refactor: prettier error on null JSON parsing

vladfaust · Oct 19, 2018 · 6511c05 · 6511c05
1 parent 242027b
commit 6511c05
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/params.cr b/src/params.cr
@@ -348,8 +348,15 @@ module Params
 
                     @initialized[{{key}}] = true
                   rescue ex : JSON::ParseException
-                    value = pull.read_raw
-                    raise ::Params::TypeCastError.new(value, value.class.name, {{value["defined_type"].stringify}}, {{key}}, @path)
+                    value = "null"
+                    klass = "Null"
+
+                    pull.read_null_or do
+                      value = pull.read_raw
+                      klass = value.class.name
+                    end
+
+                    raise ::Params::TypeCastError.new(value, klass, {{value["defined_type"].stringify}}, {{key}}, @path)
                   end
                 {% end %}
             {% end %}