Properly compares running Samba version.

vladgh · Apr 13, 2023 · f214bd9 · f214bd9
1 parent 06de1ae
commit f214bd9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/roles/server/templates/smb.conf.j2 b/roles/server/templates/smb.conf.j2
@@ -1,7 +1,7 @@
 # Samba configuration -- Managed by Ansible, please don't edit manually
 # vim: ft=samba
 #
-# {{ ansible_managed }}
+{{ ansible_managed | comment }}
 
 [global]
   # Server information
@@ -72,7 +72,7 @@
   {% endif %}
 {% endif %}
 
-{% if samba_mitigate_cve_2017_7494 and samba_version.stdout >= "3.5.0" and samba_version.stdout < "4.6.4" %}
+{% if samba_mitigate_cve_2017_7494 and samba_version.stdout is version('3.5.0', '>=') and samba_version.stdout is version('4.6.4', '<') %}
   # Fix for CVE-2017-7494 in Samba versions from 3.5.0 and before 4.6.4
   # https://access.redhat.com/security/cve/cve-2017-7494
   nt pipe support = no