Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectronMail MacOS icon problem #185

Closed
LucasGorgal opened this issue Jul 9, 2019 · 18 comments
Closed

ElectronMail MacOS icon problem #185

LucasGorgal opened this issue Jul 9, 2019 · 18 comments

Comments

@LucasGorgal
Copy link

The ElectronMail icon on notifications in MacOS is different from the main being used.
Here is a printscreen to this defective icon shown.
Xwf8Kd

@vladimiry
Copy link
Owner

I confirm the issue. Thanks for the report.

@vladimiry
Copy link
Owner

vladimiry commented Jul 10, 2019

Although the icon is being implicitly set for Linux and Windows there is something wrong on macOS. Chrome since v22 supports the explicitly specified custom icon for notifications, so going to try this option first of all.

@vladimiry vladimiry added the bug label Jul 10, 2019
@vladimiry
Copy link
Owner

vladimiry commented Jul 13, 2019

@Imparium can you try this build? Worked well for me on latest macOS.

@LucasGorgal
Copy link
Author

I am going to try it now

@LucasGorgal
Copy link
Author

No, the icon is still incorrect.

@vladimiry
Copy link
Owner

Worked well for me on macOS Catalina 10.15. At the moment I don't have another macOS system to test the stuff as well as don't have other ideas of the potential fix.

@andrewkdinh
Copy link

I have this issue when the app is in a folder. The icon will show normally when you click on the folder, but not when the folder is closed.

ElectronMail v3.7.0
MacOS Mojave v10.14.5
MacBook Pro (13-inch)

Video proof

@vladimiry vladimiry reopened this Jul 29, 2019
@vladimiry vladimiry added glitch and removed bug labels Aug 2, 2019
@vladimiry
Copy link
Owner

vladimiry commented Aug 10, 2019

Can someone confirm that v3.7.1 is affected? That version has got @electron 5 => 6 update and so maybe the issue got resolved upstream.

@andrewkdinh
Copy link

I still have the folder icon problem with v3.7.1

@BBaoVanC
Copy link

BBaoVanC commented Aug 25, 2019

I'm running v3.7.1 on my MacBook Pro, macOS Mojave 10.14.6, I also have the issue.
Looks same as the video linked by andrewkdinh.

@bit-for-byte
Copy link

@vladimiry I have the same issue. It looks like that in notifications when I get a new message.

@BBaoVanC
Copy link

This issue doesn't happen anymore for me on macOS Catalina 10.15.1, ElectronMail v3.8.0. Not sure which update fixed it.

@ylluminate
Copy link

Still having this on 10.14.6.

@vladimiry
Copy link
Owner

vladimiry commented Dec 20, 2019

This is an upstream issue as the app doesn't explicitly render the icon but only specifies the PNG image. So the only possible solution is updating @electron version or macOS version. We got the message above that updating to Catalina helps. I work on upgrading to @electron version 8 hoping that it will resolve the issue for everyone but there are still blocking upstream issues.

@vladimiry
Copy link
Owner

vladimiry commented Dec 24, 2019

Can someone who still experiences the issue test this build?

Changes:

So the build uses a dynamic/DataURL image instead of the static file, so maybe it will work around the original issue.

PS don't use this build on a regular basis as it's a little buggy (at least don't edit/add the accounts to the app).

@vladimiry
Copy link
Owner

PS don't use this build on a regular basis as it's a little buggy (at least don't edit/add the accounts to the app).

Updated the build link in previous message, it's now safe to use it on a daily basis.

@vladimiry
Copy link
Owner

vladimiry commented Jan 30, 2020

I'm closing the issues since as I wrote before it's the upstream issue and all I could do is updating the Electron versions in time (Electron version 8 is going to be released quite soon). I'd recommend trying the recent release. There are now 3 packages provided for specific macOS versions and it increases chances for better compatibility.

@macbugs
Copy link
Contributor

macbugs commented Mar 18, 2022

The issue persists in 4.13.5 - also affects file browser ("Finder") and file properties ("get info") views

Screen Shot 2022-03-18 at 14 34 56

icon

This was referenced Apr 9, 2022
vladimiry pushed a commit that referenced this issue Apr 13, 2022
- Fix for corrupted 'Finder' & notification icons
- Refs: #185, #199, #503
vladimiry pushed a commit that referenced this issue Apr 13, 2022
- Fix for corrupted Finder/app-bundle icon.
- Refs: #185, #199, #503
vladimiry pushed a commit that referenced this issue Apr 13, 2022
- Fix for corrupted Finder/app-bundle icon.
- Refs: #185, #199, #503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants