Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow "title" of pageto be same as what a web browser would show. #215

Closed
mikejzx opened this issue Nov 25, 2019 · 5 comments
Closed

Comments

@mikejzx
Copy link

mikejzx commented Nov 25, 2019

Greetings, I'd like to make a small suggestion for ElectronMail.
Simply, I think it'd be nice to see the "title" of the actual page change depending on the folder or tab being viewed within the application. The web browser version does this automatically, but doesn't appear to show in ElectronMail.

For example, when I view ProtonMail in a web browser, the title tag of the page is set to "Inbox | [REDACTED]@protonmail.ch | ProtonMail" (Shown in the image below)
electronmail-pm-browser

Whereas the application, ElectronMail, in it's current state simply shows, "ElectronMail" as the attached image below shows. (The title shown in the "taskbar" in Electron apps depends on the title tags set in the page from what I have seen in the past.)
electronmail-title

Notably, the web browser also displays a "(1)", representing an unread message. This is beneficial to users like myself who have the titles of windows visible in their taskbars/panels/etc so that it is more clear when an e-mail has not yet been read.

This could possibly be an optional feature too, just in case some users prefer the current way the title is set.

I know this is a simple thing, but since I have never used TypeScript before I couldn't see a way for myself to implement it, so decided to post it here.

Thank you.

@mikejzx mikejzx changed the title Option to allow "title" of page to change based on folder. Option to allow "title" of pageto be same as what a web browser would show. Nov 25, 2019
@vladimiry
Copy link
Owner

vladimiry commented Nov 25, 2019

I know this is a simple thing

I agree that it's manageable so let's make the feature to be planned :)

Since it's a privacy-concerning feature I think it should be an opt-in one, ie disabled by default, so the app doesn't show sensitive data in the taskbar by detault.

By the way, early releases had the inner page title displayed in the account handle button (see example). So it was like tabs in the browser :)

@vladimiry
Copy link
Owner

WIP build with the feature included is uploaded here. @mikejzx can you confirm the feature works as expected? See on the below-animated image how to enable the feature:

peek-min

@mikejzx
Copy link
Author

mikejzx commented Nov 26, 2019

WIP build with the feature included is uploaded here. @mikejzx can you confirm the feature works as expected? See on the below-animated image how to enable the feature:

peek-min

Great! It works as expected, thank you.

@vladimiry
Copy link
Owner

Thanks for testing and confirming meeting the expectation, closing as resolved then.

vladimiry added a commit that referenced this issue Nov 26, 2019
@vladimiry
Copy link
Owner

This feature is going to be removed when the app moves to ProtonMail v4 Web Client. They have split the Web Client to 4 different HTML pages/SPAs which in my opinion not only hurts the UX but also increases the burden of having the original feature supported here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants