Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database View is WHITE! #238

Closed
ylluminate opened this issue Jan 25, 2020 · 17 comments
Closed

Database View is WHITE! #238

ylluminate opened this issue Jan 25, 2020 · 17 comments

Comments

@ylluminate
Copy link

I've really never used Database View before and just realized that not only it could be helpful, BUT it's BLINDING... Can you please also implement a dark mode for it?

@vladimiry
Copy link
Owner

Some users might like light stuff. So force-turn everything to dark would be a sort of discrimination 😄 But seriously, yes, consistency of UI color scheme still to be improved.

@vladimiry
Copy link
Owner

It's not really dark yet but I've already started making the adjustments:

dbview

@ylluminarious
Copy link

@vladimiry You could always have a toggle button to allow users to switch between a light or dark theme, as they choose.

@vladimiry
Copy link
Owner

vladimiry commented Jan 27, 2020

Sure, but that would mean more work to do, so for now such toggle is not planned.

@vladimiry
Copy link
Owner

vladimiry commented Jan 27, 2020

Next iteration:
dbview

vladimiry added a commit that referenced this issue Jan 27, 2020
* make color scheme darker
* use "secondary-light" buttons
* use "btn-sm" buttons size
* turn "export" link to button
* improve compactness
@vladimiry
Copy link
Owner

I think I prefer less standing out badges on the mail rows:
dbview

@vladimiry
Copy link
Owner

vladimiry commented Jan 27, 2020

Improved highlighting consistency, like borders/font colors (this will be it for now):

dbview

vladimiry added a commit that referenced this issue Jan 27, 2020
* make badges on mail row less standing out by removing its background
* adjust selected mail highlighting (inner elements get proper/golden color and borders)
@vladimiry
Copy link
Owner

Here is the dark version but I'm going to keep lighter/on-previous-screenshot version for now:
dbview

@ylluminarious
Copy link

@vladimiry Why not use that darker version? Would at least be slightly easier on the eyes...

@vladimiry
Copy link
Owner

vladimiry commented Jan 27, 2020

I've not finally decided which version becomes default until the mode toggle gets implemented. But I tried both and the lighter version was somewhat more comfortable to read text. I didn't do much testing though.

@vladimiry
Copy link
Owner

lighter version was somewhat more comfortable to read text

Maybe it's because the overall page contrast is high and so I should try turning the body part of the email background to dark mode too (right side on the screenshot).

@ylluminarious
Copy link

@vladimiry That sounds like a good idea which might make it easier to read, yes.

vladimiry added a commit that referenced this issue Jan 27, 2020
* reduce folder items height (by making its height equal to the mail item height)
vladimiry added a commit that referenced this issue Jan 27, 2020
vladimiry added a commit that referenced this issue Jan 27, 2020
vladimiry added a commit that referenced this issue Jan 27, 2020
* use lighter version by default for now
vladimiry added a commit that referenced this issue Jan 28, 2020
vladimiry added a commit that referenced this issue Jan 29, 2020
vladimiry added a commit that referenced this issue Jan 29, 2020
@vladimiry
Copy link
Owner

Closing the issue in favor of #242.

The following change has been included in just published v4.2.1 release.

@ylluminate
Copy link
Author

ylluminate commented Jan 29, 2020

Better, thanks @vladimiry 😅 The only thing I notice missing now is a command-q not quitting and command-, not giving preferences/settings on macOS.

On the dark side, hopefully this will evolve at some point when you can consider a full mode switched as I believe you're pondering on.

@vladimiry
Copy link
Owner

On the dark side, hopefully this will evolve at some point when you can consider a full mode switched as I believe you're pondering on.

It's supposed to evolve, one day, subscribe to #242.

@ylluminate
Copy link
Author

Thank you so much.

@ylluminarious
Copy link

@vladimiry Thanks, it does look a little better now. Looking forward to the full dark release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants