Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include account name in notification #280

Closed
ThHareau opened this issue Apr 14, 2020 · 6 comments
Closed

Include account name in notification #280

ThHareau opened this issue Apr 14, 2020 · 6 comments
Labels

Comments

@ThHareau
Copy link

Hello,

Would it be possible to include the account name in the notification?

image

The index of the account is not really helpful.

I think that the main email attached to the account would be more useful (something like: email@domain.tld: 24 new emails).

@vladimiry
Copy link
Owner

vladimiry commented Apr 14, 2020

Initially, the login name was displayed in the notification message but then got turned to the index due to the privacy matters. We didn't have the aliasing feature at that time but we got aliasing supported since v4.0.0 and so I think it's ok to render the alias in the notification message. If no alias value defined then it would still be the index. Any thoughts on the described scenario?

@ThHareau
Copy link
Author

For me at least, alias is perfect.

@vladimiry
Copy link
Owner

Alias displaying in desktop notification message is going to be enabled in the next release, 04fc659.

@ThHareau
Copy link
Author

That's awesome @vladimiry , I didn't expected it to be implemented that fast!
Thanks a lot

@vladimiry
Copy link
Owner

That was very easy change since we already had all the data in the store.

@vladimiry
Copy link
Owner

You can find in this message a link to the most actual work-in-progress build with 04fc659 change included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants