Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option to manually enable and load email accounts #316

Closed
Aikatsui opened this issue Aug 13, 2020 · 15 comments
Closed

Allow option to manually enable and load email accounts #316

Aikatsui opened this issue Aug 13, 2020 · 15 comments

Comments

@Aikatsui
Copy link

Current way atleast primary mailbox automatically load and login when open electronmail and it seems rest of them get loaded as well. Logout from certain mailboxes also not possible. Can you enhance settings page for,

  • Logout (manually logout certain mailbox and notify confirmation dialog to login again)
    (This feature for already logon accounts after launched the app and it doesn't remember that for next launch)
  • Disable (this's a permanent option for disable certain mailbox until enable again also disappear from main window)
    (When user click disable then the account should logout first then disable it in UI)

Example: https://github.com/ramboxapp/community-edition
Screenshot from 2020-08-12 15-00-39

It has option(area) in right side for enable or disable services but i'm not prefer electronmail implement the same and separate page because i dont like people abuse the protonmail and use accounts for bad purposes or bother, harm people.

@vladimiry
Copy link
Owner

The requested feature is already there, enabled since v3.1.0. Also, I guess you might want to explore the persistent session feature too.

123

@Aikatsui
Copy link
Author

Aikatsui commented Aug 25, 2020

No. I mean these options.

Screenshot from 2020-08-26 01-56-00

  1. Color - account status
  2. Logout - temporally logout account (until reboot or relaunch app)
    (Shouldn't disappear from main screen and if user click on that tab then ask confirmation to relogin)
  3. Enable or Disable - Permanently enable and disable accounts.
    (Disappear from login screen)

@vladimiry
Copy link
Owner

No. I mean these options.

Won't fix then.

@Aikatsui
Copy link
Author

Won't fix then.

But what's the reason for consider to ignore it?

@vladimiry
Copy link
Owner

A balance of demand / increased complexity of code&maintainability&UX / my capacity / etc.

@Aikatsui
Copy link
Author

A balance of demand / increased complexity of code&maintainability&UX / my capacity / etc.

However i think this might be a useful feature also essential for multiple accounts own users. Someone may able to help if this keep opened or you can implement when less issues in repository.

@vladimiry
Copy link
Owner

vladimiry commented Aug 28, 2020

Someone may able to help if this keep opened or you can implement when less issues in repository.

It's not only about implementing some new feature but also about supporting it in the future since in general the maintenance burden gets increased with code base growing. So even if someone will be willing to implement the requested feature I won't be accepting it in this protect at this time which means that should be maintained as a fork by the feature author.

@ghost
Copy link

ghost commented Sep 4, 2020

Someone may able to help if this keep opened or you can implement when less issues in repository.

It's not only about implementing some new feature but also about supporting it in the future since in general the maintenance burden gets increased with code base growing. So even if someone will be willing to implement the requested feature I won't be accepting it in this protect at this time which means that should be maintained as a fork by the feature author.

Late visit :)
I'm also multiple protonmail accounts user so i especially concern about that.

Can't you just add only a enable/disable option?, discarding everything else mentioned by @kizunaH (it seems new facilities and UI enhancements she suggested for electronmail) so It'll not expand the codebase as you make sounds.

(The simple goal is to ensure and prevent particular mailboxes get network access. that's what we expect as multiple account users. When enable then it can follow the normal login procedure to load the mailbox or it can be either persistent session according configuration made when add mailbox or simple task like break the domain to box or something like that when disable it. Anyway as easy for you with minimum code lines)

Both are electron based apps and you can minimize what've done to implement that option in rambox
https://github.com/ramboxapp/community-edition

Screenshot from 2020-09-05 02-18-16

@vladimiry vladimiry reopened this Sep 5, 2020
@vladimiry
Copy link
Owner

Adding only the disabling toggle near to the account is not a big change indeed.

vladimiry added a commit that referenced this issue Sep 5, 2020
@vladimiry
Copy link
Owner

The feature is on the way:

issue-316

@vladimiry
Copy link
Owner

The feature by the way works nicely with the persistent session feature. Means you can deactivate and activate the account back having the login form skipped. The app doesn't drop the saved session if any but only disables the account loading/rendering.

@ghost
Copy link

ghost commented Sep 5, 2020

@vladimiry 🥇

@vladimiry
Copy link
Owner

If someone wants to try the WIP build with the enabled feature, it's uploaded here.

vladimiry added a commit that referenced this issue Sep 6, 2020
* so the cursor style is consistent across the app (no "pointer" cursor applied to the rest toggles)
@Aikatsui
Copy link
Author

Aikatsui commented Sep 6, 2020

Nice to see this feature quick. :)

vladimiry added a commit that referenced this issue Sep 7, 2020
* so the cursor style is consistent across the app (no "pointer" cursor applied to the rest toggles)
vladimiry added a commit that referenced this issue Sep 7, 2020
* the app should not fire ACCOUNTS_ACTIONS.PatchProgress action for disabled accounts
vladimiry added a commit that referenced this issue Sep 7, 2020
* so the cursor style is consistent across the app (no "pointer" cursor applied to the rest toggles)
vladimiry added a commit that referenced this issue Sep 7, 2020
* ACCOUNTS_ACTIONS.PatchProgress action should not be fired for disabled accounts
@vladimiry
Copy link
Owner

vladimiry commented Sep 7, 2020

Updated WIP build uploaded here (fixed "Failed to resolve account" error occuring).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants