Default electron tray icon on GNOME

[Vallasc]

I'm on GNOME and it show the default electron tray icon instead of showing the app logo.

[vladimiry]

The issue is not reproducible on Ubuntu 21.04 with Gnome 3.38.5. The app was installed from https://snapcraft.io/electron-mail.

Did you install it form https://snapcraft.io/electron-mail ?

[Vallasc]

I installed it via flathub
Pop!_OS 21.04
GNOME 3.38.4

[vladimiry]

Can you also test the DEB package and/or https://snapcraft.io/electron-mail?

[Vallasc]

I tried the AppImage and DEB version but the issue persists

[vladimiry]

Thanks. It appears to be the Pop!_OS specific then. I'm not going to install the Pop!_OS in the near future to troubleshoot the issue.

[vladimiry]

Does setting the XDG_CURRENT_DESKTOP=Unity env variable make any difference?

[Vallasc]

No difference

[vladimiry]

Thanks. So for now it would be up to someone who uses Pop!_OS to find the workaround.

[Vallasc]

I think the error is on tray.ts

On line 13
const tray = new Tray(nativeImage.createEmpty());

You should pass the image path to the Try constructor.
I tried to edit the file but I can't find the path of the icon.

[vladimiry]

@Vallasc, it's a lot more complex than you have explored so far. Locate the tray.setImage() calls in https://github.com/vladimiry/ElectronMail/blob/master/src/electron-main/api/endpoints-builders/tray-icon/index.ts. The tray icon is dynamically/programmatically rendered.

[vladimiry]

The app has been installed from flathub (via default PopOS's app manager). Clean system (VirtualBox).

[Vallasc]

I found the problem. Disabling Papirus icon pack the icon is shown in the right way.

[vladimiry]

Thanks for sharing the issue cause.

[vladimiry]

It appears that papirus-icon-theme does something with the tray icons for some reason https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/search?q=electronmail&type=commits

[Vallasc]

I have removed all electron icons from the icon theme directory and now it works as it should. Thanks.

[varlesh]

It appears that papirus-icon-theme does something with the tray icons for some reason https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/search?q=electronmail&type=commits

We not doing something with the tray icons. Application use electron icon name instead of electron-mail.
It's not our bug.

[varlesh]

@vladimiry Вообще Papirus ничего не ломает и hardcode-tray тоже.
Ваш значок (раскрашенный в #dfdfdf):

Наш значок, с hardcode-tray (с дефолтным цветом #1ba489):

Проверенно в KDE. Для правильной логики программы могу просто перекрасить значок для трея в цвет #1ba489 и всё будет работать как и задумано.

[varlesh]

Пофиксил, наш значок не ломает логику разукрашивания значка и все работает как и положено.
По факту, наши костыли ненужны и ваше решение очень крутое. Но hardcode-tray и Papirus подгоняет размер значка и он не будет больше или меньше других в трее, ну и плюс выравнивание по пикселям, т.к. GNOME использует 16px, KDE 22px, а XFCE может само выбрать нужный размер.

[vladimiry]

We not doing something with the tray icons. Application use electron icon name instead of electron-mail.
It's not our bug.

Does something means exactly this, doing something. I didn't look deep into the commit.

Для правильной логики программы могу просто перекрасить значок для трея в цвет #1ba489 и всё будет работать как и задумано.

Yep, the #1ba489 value is hardcoded in the app as a base color of the static tray icon. So the app then could use that value as a base color for recoloring when the respective settings gets changed in the app as displayed in #464 (comment).

Anyway, the outcome is that papirus-icon-theme got the fix so now it doesn't break the app's UX-related features and fills the ticks of its own checklist at the same time which should be good for everyone.