Wrap async generators with contextlib.aclosing #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylolz
force-pushed
the
158-aclosing-everywhere
branch
from
9b272e9
to
0244ec1
Compare
|
Very much thanks for your contribution! It's frustrating to wrap everything in |
|
Many thanks for merging – and thanks again for the library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158 – more details there.
It seems the
aclosingcontext manager needs to be called for each nestedasync forloop. This PR does that.Looks like #30 may have been due to the same problem – so this should resolve that, too.