New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL link is broken inside Readme.md -MySQL section "here" link in sentense "Exact instructions can be found in here." #18

Closed

mingqin1 opened this issue Feb 16, 2018 · 5 comments

mingqin1 commented Feb 16, 2018

The here link is pointed to https://github.com/ursjoss/high-performance-java-persistence/blob/tb_mysql_instructions/MYSQL.md , which leads to 404 error

The correct link might be https://github.com/vladmihalcea/high-performance-java-persistence/blob/master/MYSQL.md

ursjoss commented Feb 16, 2018 •

edited

The correct link can be found in pull request #9

ursjoss commented Feb 16, 2018

For those interested: https://github.com/ursjoss/high-performance-java-persistence/commit/88373dc7c2080d02e2e3965afae961495e7d956b

ursjoss commented Feb 16, 2018

In my fork, I am trying to keep up with Vlad's changes in an eclipse friendly way (branch [tb_eclipse]
(https://github.com/ursjoss/high-performance-java-persistence/tree/tb_eclipse)). At least when not on holiday w/o laptop, as just now... 😎

Owner

vladmihalcea commented Feb 16, 2018

Fixed. Thanks for pointing it out.

vladmihalcea closed this as completed

ursjoss commented Feb 16, 2018

Oops, sorry for the noise... I was mislead by the first part of the link 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment