Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Changes on javascript OOP way in Nano class #11

Merged
merged 6 commits into from
Jun 1, 2018

Conversation

seymourpoler
Copy link
Contributor

@seymourpoler seymourpoler commented May 27, 2018

Hi,

I´ve rewrite the Nano class, chaging the oop way.

Thank you for your code.
Best regards
Luis

@vladocar
Copy link
Owner

I like it thanks!
Because let is only supported in IE12 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let can be changed with var?
It is important that most of methods run in IE9.

@seymourpoler
Copy link
Contributor Author

Hi Vladimir,
I´ve changed 'let' with 'var'

@vladocar
Copy link
Owner

Hi Luis
Yes, I've tried with 'var' locally yesterday and it works. However I have better idea we can use 'let' and entire re-write in a dedicated lab folder of the project as alternative. Otherwise I need to change entire code structure and mindset.

@seymourpoler
Copy link
Contributor Author

Hi Vladimir,

I´ve added a dedicated lab folder (called lab) of the project as alternative with new ideas, as we commented.

Regards
Luis

@vladocar
Copy link
Owner

vladocar commented Jun 1, 2018

Ok, perfect!

@vladocar vladocar merged commit 4992fa3 into vladocar:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants