Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node engine version limit #122

Closed
Christian-Seematter opened this issue Nov 2, 2016 · 4 comments
Closed

Node engine version limit #122

Christian-Seematter opened this issue Nov 2, 2016 · 4 comments

Comments

@Christian-Seematter
Copy link

Christian-Seematter commented Nov 2, 2016

I've got a node package that uses "ng-semenatic": "^1.1.11", however yarn install fails because ng-semantic restricts node versions > 6 in package.json:

"engines": {
"node": ">= 5.4.1 < 6"
},

image

This error can be circumvented with yarn install --ignore-engines, however I belive current node version to be supported. As far as I am aware npm does not check for this, yarn however does.

@vladotesanovic
Copy link
Owner

Ok, this should be changed.

I saw now that angular team also increased version in their repository, i ll do the same.

https://github.com/angular/angular/blob/master/package.json#L10

Madsn added a commit to Madsn/ngSemantic that referenced this issue Nov 18, 2016
@Madsn
Copy link
Contributor

Madsn commented Nov 25, 2016

I guess this can be closed now?

@vladotesanovic
Copy link
Owner

👍 correct

@Christian-Seematter
Copy link
Author

Christian-Seematter commented Nov 29, 2016

I've seen that the pull request for this was merged into master and build successfully. When will this be available via the npm repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants