Update to Angular 4, Fix ngSemantic is not a Module #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed ngSemantic is not a module by using [@borisfeldmann](https://github.com/borisfeldmann) [solution](#149 (comment)) - Updated dependencies to more up to date angular - Fixed errors due to new angular version like dependencies on Tab and Accordion - Zone.js in demo - Removed Directive in Accordion, instead using the Accordion Component to initiate Jquery and input options
mp3sii
changed the title
|
@mp3sii really need this fix but it seems this project is stalled since December 2016. |
|
Would also be keen to see this resolved |
|
What is the blocking point to fix this major issue ? |
|
@vladotesanovic any plans to make it work with Angular 4? |
|
Now I'm using "ng2-semantic-ui" package which works perfectly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day vladotesanovic.
I made a few changes in order to fix and update ngSemantic with new angular. This is related with the issue of ngSemantic is not a module. #149
This is the list of the changes:
Fixed ngSemantic is not a module by using @borisfeldmann [solution] (NgSemantic is not a module #149 (comment))
Changed and updated dependencies. Mainly:
Fixed errors due to upgrade angular4 and cli, these included errors in Tab and Accordion
Some TODOs:
This is my first pull request ever, and I would understand if you decide to implement this changes on your own. Hopefully this would help you.
Thank you for this project