Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep directory structure using the flattened mode #36

Conversation

hrodriguez758
Copy link

The merge request solve the issue #32

@hrodriguez758
Copy link
Author

@mario-d-s @vladshcherbin Check it and let me know if you need to know something or if I have to change anything.

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          36     37    +1     
  Branches       12     13    +1     
=====================================
+ Hits           36     37    +1
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57df513...c1ed1b2. Read the comment docs.

@LarsDenBakker
Copy link

+1 this is a very useful feature to have

@alejandroclaro
Copy link

@vladshcherbin anything wrong with this?

This is really helpful. +1

@vladshcherbin vladshcherbin merged commit a7ea915 into vladshcherbin:master Jan 16, 2020
@vladshcherbin
Copy link
Owner

@hrodriguez758 Thank you ❤️

I've slightly updated it and released in 3.2.0. Please test in your projects to see if it's working as expected.

@LarsDenBakker
Copy link

@vladshcherbin it looks like it's removing the first part of the directory structure, for example if I copy a file /node_modules/foo/bar/assets/my-image.png it gets copied as foo/bar/assets/my-image.png

@hrodriguez758
Copy link
Author

@LarsDenBakker That happened because the code takes the first folder as the root source (src/**) and that folder name is replaced by the dest source (dist/**). However, you can add the node_modules path in the destination source and the code will append it with foo/bar/assets/my-image.png. Check it and let me know if you still have an issue with the current behavior.

@LarsDenBakker
Copy link

That seems like a bug to me, the option advertises to keep the directory structure when it is actually not. I am copying from multiple directories, so now I need to split up my glob and manually prefix each directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants