Update default values in types (globby, fast-glob) #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We are setting both
onlyFiles
andexxpandDirectories
options tofalse
here as they are set totrue
by default in globby and fast-glob.In VSCode the autocomplete currently shows with
![Screenshot 2023-09-19 at 15 00 13](https://private-user-images.githubusercontent.com/34352395/268982088-f3aa598e-5ee3-4f42-98b3-5067c32ec8f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4NDA1NjUsIm5iZiI6MTcyMTg0MDI2NSwicGF0aCI6Ii8zNDM1MjM5NS8yNjg5ODIwODgtZjNhYTU5OGUtNWVlMy00ZjQyLTk4YjMtNTA2N2MzMmVjOGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI0VDE2NTc0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZlMTQ5Y2JkZGY4MDZhN2U1NDQ0Y2MyNDMxZWRkNmY2NjYyMmNjZDc5YWU2ZDAyMDNiY2JjYjMzM2E0MmQ5YjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I06n6D4qlNT0m26fBPjtEMRNDKdAa4txe3aYQTSaaj4)
@default: true
text so I really assumed that it is really set to true before looking at source code.This PR changes the
![Screenshot 2023-09-19 at 15 05 44](https://private-user-images.githubusercontent.com/34352395/268983794-650f093d-5d85-4723-ad42-d61d455021c7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4NDA1NjUsIm5iZiI6MTcyMTg0MDI2NSwicGF0aCI6Ii8zNDM1MjM5NS8yNjg5ODM3OTQtNjUwZjA5M2QtNWQ4NS00NzIzLWFkNDItZDYxZDQ1NTAyMWM3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI0VDE2NTc0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5MzgzNGMxYmU0OGUyM2ZkNjhmOGQzMmZkZjBmNjdhNjA1MmJjYmU1M2RiNjU1MDllZjQ4M2RjOTU2ODFiMTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-kP929e5DrUXFzqPXEDu44qr5_RFT9AXmZhfLohQoKw)
@default
flag tofalse
so it's inline with this rollup-plugin-copy options.Not sure if there is a better way of changing intellisense
@default
from 'true' to 'false'. I've copied the type declaraitions from both globby and fast-glob and just changed the default values.