Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When location is set all weatherEntries are now updated using City Name instead of City ID #54

Merged
merged 2 commits into from
Apr 25, 2023
Merged

When location is set all weatherEntries are now updated using City Name instead of City ID #54

merged 2 commits into from
Apr 25, 2023

Conversation

Bryan0x05
Copy link
Collaborator

This is because City ID infrastructure is not rolled out yet and I jumped the gun.

@Bryan0x05
added City name support for locUpdate and commented out city ID support
659fbd8 
Since City ID support is not ready to roll out yet.
mishta-bean
mishta-bean approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@mishta-bean mishta-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@Bryan0x05 Bryan0x05 merged commit 9e1e173 into master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishta-bean mishta-bean mishta-bean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bryan0x05 @mishta-bean