imporve error position

vlang · Apr 5, 2024 · 08c02a9 · 08c02a9
1 parent e034cbc
commit 08c02a9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/vlib/v/checker/struct.v b/vlib/v/checker/struct.v
@@ -748,8 +748,13 @@ or use an explicit `unsafe{ a[..] }`, if you do not want a copy of the slice.',
 							} else {
 								parts.last()
 							}
-							c.error('cannot access private field `${field.name}` on `${mod_type}`',
-								node.pos)
+							for init_field in node.init_fields {
+								if field.name == init_field.name {
+									c.error('cannot access private field `${field.name}` on `${mod_type}`',
+										init_field.pos)
+									break
+								}
+							}
 						}
 						if field.is_deprecated {
 							for init_field in node.init_fields {

diff --git a/vlib/v/checker/tests/struct_field_private_err.out b/vlib/v/checker/tests/struct_field_private_err.out
@@ -1,12 +1,12 @@
-vlib/v/checker/tests/struct_field_private_err.vv:7:11: error: cannot access private field `x` on `amod.Bcg`
-    5 | }
+vlib/v/checker/tests/struct_field_private_err.vv:8:2: error: cannot access private field `x` on `amod.Bcg`
     6 | 
     7 | _ := amod.Bcg{
-      |           ~~~~
     8 |     x: 0
+      |     ~~~~
     9 | }
+   10 |
 vlib/v/checker/tests/struct_field_private_err.vv:11:10: error: cannot access private field `bar` on `amod.FooParams`
     9 | }
    10 | 
    11 | amod.foo(bar: 'bar')
-      |          ~~~~~~~~~~~
+      |          ~~~~~~~~~~