Skip to content

Commit

Permalink
io.string_reader: fix needs_fill_until check (#21005)
Browse files Browse the repository at this point in the history
  • Loading branch information
daddycocoaman committed Mar 13, 2024
1 parent 8ec990e commit 54da256
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
2 changes: 1 addition & 1 deletion vlib/io/string_reader/string_reader.v
Expand Up @@ -52,7 +52,7 @@ pub fn (r StringReader) needs_fill() bool {
// needs_fill_until returns whether the buffer needs refilling in order to read
// `n` bytes
pub fn (r StringReader) needs_fill_until(n int) bool {
return r.offset + n >= r.builder.len
return r.offset + n > r.builder.len
}

// fill_bufer tries to read data into the buffer until either a 0 length read or if read_to_end_of_stream
Expand Down
14 changes: 14 additions & 0 deletions vlib/io/string_reader/string_reader_test.v
Expand Up @@ -89,6 +89,20 @@ fn test_from_string() {
}
}

fn test_from_string_read_byte_one_by_one() {
mut reader := StringReader.new(source: 'test')
assert reader.read_bytes(1)![0].ascii_str() == 't'
assert reader.read_bytes(1)![0].ascii_str() == 'e'
assert reader.read_bytes(1)![0].ascii_str() == 's'
assert reader.read_bytes(1)![0].ascii_str() == 't'

if _ := reader.read_all(false) {
assert false, 'should return Eof'
} else {
assert err is io.Eof
}
}

fn test_from_string_and_reader() {
buf := Buf{
bytes: 'buffer'.bytes()
Expand Down

0 comments on commit 54da256

Please sign in to comment.