checker: extend byte deprecation warning to struct fields (#19653)

vlang · Oct 28, 2023 · 705eea8 · 705eea8
1 parent 573188a
commit 705eea8
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 22 deletions.
diff --git a/vlib/v/ast/type_size_test.v b/vlib/v/ast/type_size_test.v
@@ -4,7 +4,7 @@ import v.pref
 
 struct T01 {
 	a int
-	b byte
+	b u8
 	c int
 }
 

diff --git a/vlib/v/checker/struct.v b/vlib/v/checker/struct.v
@@ -131,30 +131,37 @@ fn (mut c Checker) struct_decl(mut node ast.StructDecl) {
 					}
 				}
 			}
-			if sym.kind == .struct_ {
-				info := sym.info as ast.Struct
-				if info.is_heap && !field.typ.is_ptr() {
-					struct_sym.info.is_heap = true
+			match sym.kind {
+				.struct_ {
+					info := sym.info as ast.Struct
+					if info.is_heap && !field.typ.is_ptr() {
+						struct_sym.info.is_heap = true
+					}
+					for ct in info.concrete_types {
+						ct_sym := c.table.sym(ct)
+						if ct_sym.kind == .placeholder {
+							c.error('unknown type `${ct_sym.name}`', field.type_pos)
+						}
+					}
+				}
+				.multi_return {
+					c.error('cannot use multi return as field type', field.type_pos)
+				}
+				.none_ {
+					c.error('cannot use `none` as field type', field.type_pos)
 				}
-				for ct in info.concrete_types {
-					ct_sym := c.table.sym(ct)
-					if ct_sym.kind == .placeholder {
-						c.error('unknown type `${ct_sym.name}`', field.type_pos)
+				.map {
+					info := sym.map_info()
+					if info.value_type.has_flag(.result) {
+						c.error('cannot use Result type as map value type', field.type_pos)
 					}
 				}
-			}
-			if sym.kind == .multi_return {
-				c.error('cannot use multi return as field type', field.type_pos)
-			}
-
-			if sym.kind == .none_ {
-				c.error('cannot use `none` as field type', field.type_pos)
-			}
-			if sym.kind == .map {
-				info := sym.map_info()
-				if info.value_type.has_flag(.result) {
-					c.error('cannot use Result type as map value type', field.type_pos)
+				.alias {
+					if sym.name == 'byte' {
+						c.warn('byte is deprecated, use u8 instead', field.type_pos)
+					}
 				}
+				else {}
 			}
 
 			if field.has_default_expr {
@@ -208,7 +215,6 @@ fn (mut c Checker) struct_decl(mut node ast.StructDecl) {
 						}
 					}
 				}
-
 				if field.typ.has_flag(.option) {
 					if field.default_expr is ast.None {
 						c.warn('unnecessary default value of `none`: struct fields are zeroed by default',