New string interpolation in V #10181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em return for floats string interpolation
…tr lead to the same string data pointed to by 2 different strings
|
Please remove sqlite3.h :) |
|
Done :) |
|
I need to check under MSVC what it is happening :( sigh... |
* spytheman/str_int: fix interpolation tests (pass for clang,gcc,tcc) fix u16 interpolation with clang
|
Strange... localy on my windows pc, the failing test pass without problems: PS C:\Dev\temp\v> ./v.exe -cc msvc -os windows -o v2.exe .\cmd\v
PS C:\Dev\temp\v> .\v2.exe -cc msvc test .\vlib\v\tests\break_in_lock_test.v
---- Testing... --------------------------------------------------------------
OK 825.070 ms .\vlib\v\tests\break_in_lock_test.v
------------------------------------------------------------------------------
Summary for all V _test.v files: 1 passed, 1 total. Runtime: 825 ms. |
|
@spytheman @medvednikov All green guys! 🎉 |
|
Amazing job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's inside
The new
string interpolationentirely written in V.The code is a starting point, a lot of optimization on size and speed can be done.
I want to thanks @spytheman for the precious support in the test phase of this PR!