Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml: add excerpt to value parse errors #12429

Merged

Conversation

Larpon
Copy link
Contributor

@Larpon Larpon commented Nov 10, 2021

Before:

OK   [32/189] "/home/user/v/vlib/toml/tests/testdata/burntsushi/toml-test/tests/invalid/integer/double-sign-plus.toml"...
     toml.parser.Parser.value value expected .boolean, .quoted, .lsbr, .lcbr or .number got "plus" "+"

After:

OK   [32/189] "/home/user/v/vlib/toml/tests/testdata/burntsushi/toml-test/tests/invalid/integer/double-sign-plus.toml"...
     toml.parser.Parser.value value expected .boolean, .quoted, .lsbr, .lcbr or .number got "plus" "+" in this (excerpt): "...n-plus = ++99\n..."

(My plan, btw - is to polish the error excerpts to be more like V's sometime in the future)

@spytheman spytheman merged commit 015cfdb into vlang:master Nov 11, 2021
@Larpon Larpon deleted the toml/add-excerpt-to-value-parse-error branch November 11, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants