Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix orm unreachable code checking #16948

Merged
merged 6 commits into from
Jan 12, 2023

Conversation

felipensp
Copy link
Member

Fix #16330

sql dbs {
        insert repo into Target
    } or {
        println(err)
        return 1
    }
    assert true // checker was pointing as unreachable code
    return 1 

@enghitalo
Copy link
Contributor

I was waiting for this, too!! Thanks, man!

@felipensp felipensp marked this pull request as ready for review January 12, 2023 11:50
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit ba091a3 into vlang:master Jan 12, 2023
@felipensp felipensp deleted the fix_return_checking_orexpr branch January 12, 2023 15:56
medvednikov pushed a commit that referenced this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler incorrectly determines scope for sql "or" statements
3 participants