Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix missing check for or expr on string interpolation #17566

Merged
merged 8 commits into from
Apr 23, 2024
Merged

checker: fix missing check for or expr on string interpolation #17566

merged 8 commits into from
Apr 23, 2024

Conversation

felipensp
Copy link
Member

Fix #17475

@JalonSolov JalonSolov closed this Mar 23, 2023
@JalonSolov JalonSolov reopened this Mar 23, 2023
@spytheman spytheman added the Needs Rebase The code of the PR must be rebased over current master before it can be approved. label Aug 21, 2023
@felipensp felipensp mentioned this pull request Apr 4, 2024
Closed
@felipensp felipensp marked this pull request as ready for review April 13, 2024 14:24
@felipensp felipensp added Unit: Checker Bugs/feature requests, that are related to the type checker. and removed Needs Rebase The code of the PR must be rebased over current master before it can be approved. labels Apr 13, 2024
@felipensp
Copy link
Member Author

Looks like we should fix nohup on coreutils. What do you think @spytheman ?

@JalonSolov
Copy link
Contributor

Definitely should be fixed.

@spytheman
Copy link
Member

Fixed in vlang/coreutils@5503d3e .

@spytheman
Copy link
Member

spytheman commented Apr 23, 2024 •
edited

It would have to be rebased over latest master @felipensp .

You are faster than me :-)

spytheman
spytheman approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Sorry for not reviewing it earlier.
I do not know how I missed it :-| .

@spytheman spytheman merged commit 0059ca8 into vlang:master Apr 23, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
Unit: Checker Bugs/feature requests, that are related to the type checker.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type mixup in a string templating expression not caught by compiler
3 participants
@felipensp @JalonSolov @spytheman